fix(runtime): preserve full-mode Markdown contrast - #311
Open
xiaotiepen wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary / 摘要
taskMode=full, so explicit light themes do not inherit the native dark-shell white text.fullstate without changing artwork, veil strength, or theme-package contents.Closes #309
Type / 类型
Platform / 平台
Self-check / 自测
Docs-only / 仅文档
macOS (when code under
macos/changes)macos/tests/run-tests.shpassed / 已通过macos/scripts/doctor-macos.shverify-dream-skin-macos.shor Desktop VerifyWindows (when code under
windows/changes)install/start/verify/restorescripts exercised / 已按改动跑过对应脚本User-facing / 用户可见变更
macos/CHANGELOG.md(andmacos/VERSIONif release-worthy) / 已更新 changelog(发版时再 bump VERSION)Security / 安全
127.0.0.1) where applicable / CDP 仍仅本机回环(如适用)Notes / 补充
taskMode=fulltheme. Before the patch, visible Markdown computed torgb(255, 255, 255)while--ds-textwas#1a1b1e; the equivalent runtime patch computes torgb(26, 27, 30)and leaves the full-mode veil unchanged.node tools/sync-runtime-assets.mjs --check, macOS and Windows renderer runtime tests, both platform payload checks, nested-:has()checks, andgit diff --check.CODEX_DREAM_SKIN_SKIP_SIGNED_RUNTIME_TESTS=1 CODEX_DREAM_SKIN_SKIP_DOCTOR=1 bash macos/tests/run-tests.sh. Signed installed-runtime integration and Doctor were skipped because this host's installed 1.5.6 engine contains the equivalent local hotfix; native SwiftPM/XCTest was skipped by the suite because a full matching Xcode platform is unavailable.